test_verursacher.py 8.0 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153
  1. """Production assignee handlers and SQL, with SQL Server lock hints adapted for SQLite."""
  2. import re
  3. import unittest
  4. from unittest.mock import patch
  5. from urllib.parse import parse_qs, urlencode, urlsplit
  6. from app.navigation import normalize_page_url
  7. from app.verursacher import STATE_SQL
  8. from tests import test_forderung_history as fixture
  9. class VerursacherTests(unittest.TestCase):
  10. def setUp(self):
  11. self.fixture = fixture.HistoryTests()
  12. self.fixture.setUp()
  13. self.addCleanup(self.fixture.doCleanups)
  14. self.db, self.client = self.fixture.db, self.fixture.client
  15. self.db.connection.executescript("""
  16. ALTER TABLE dbo.Forderungen_Kopf ADD Verursacher_Benutzer_ID TEXT;
  17. ALTER TABLE dbo.Forderungen_Kopf ADD Verursacher_Text TEXT;
  18. UPDATE dbo.Forderungen_Kopf SET Verursacher_Benutzer_ID = 'original', Verursacher_Text = 'Original Person';
  19. INSERT INTO dbo.Benutzer_Rolle (Benutzer_ID, Name, Rolle_Name) VALUES
  20. ('original', 'Original Person', 'Service'),
  21. ('alice', 'Alice', 'Service'), ('alice', 'Alice', 'Buchhaltung'),
  22. ('bob', 'Bob', 'Leitung'), ('id-only', NULL, NULL), ('', 'Invalid', 'Service');
  23. CREATE TABLE dbo.Forderungen_Details (
  24. Client_DB TEXT, Beleg_Nr TEXT, Verursacher_Benutzer_ID TEXT,
  25. Bearbeitet TEXT DEFAULT 'N', Versicherung TEXT DEFAULT 'N', Wiedervorlage TEXT,
  26. PRIMARY KEY (Client_DB, Beleg_Nr)
  27. );
  28. """)
  29. self.db.connection.commit()
  30. execute = self.db.execute
  31. def adapted(query, values=None):
  32. sql = re.sub(r'\s+WITH \(UPDLOCK, HOLDLOCK\)', '', str(query))
  33. result = execute(sql, values)
  34. result.all = lambda: result.rows
  35. return result
  36. mocked = patch.object(self.db, 'execute', side_effect=adapted)
  37. mocked.start(); self.addCleanup(mocked.stop)
  38. self.db.rollback = self.db.connection.rollback
  39. self.origin = '/app/forderungen/liste?Filiale=10&Verursacher=Original'
  40. def url(self, view='details', key='1_R1'):
  41. return f'/app/forderungen/{view}/{key}/verursacher?' + urlencode({'return_to': self.origin})
  42. def get(self, view='details', key='1_R1'):
  43. return self.client.get(self.url(view, key), headers={'HX-Request': 'true'})
  44. def post(self, identity='alice', action='assign', view='details', key='1_R1', **extra):
  45. return self.client.post(self.url(view, key), data={
  46. 'benutzer_id': identity, 'action': action, **extra,
  47. }, headers={'HX-Request': 'true', 'X-CSRF-Token': 'csrf'})
  48. def row(self):
  49. return self.db.connection.execute('SELECT * FROM dbo.Forderungen_Details WHERE Client_DB = ? AND Beleg_Nr = ?', ('1', 'R1')).fetchone()
  50. def test_modal_deduplicates_people_but_keeps_all_roles_and_preselection(self):
  51. response = self.get()
  52. self.assertEqual(response.status_code, 200)
  53. self.assertNotIn('<html', response.text)
  54. self.assertEqual(response.text.count('value="alice"'), 1)
  55. self.assertNotIn('value="" data-roles=', response.text)
  56. self.assertIn('value="original" data-roles=', response.text)
  57. self.assertIn('selected>Original Person', response.text)
  58. self.assertIn('id-only (id-only)', response.text)
  59. for role in ['Service', 'Buchhaltung', 'Leitung']:
  60. self.assertIn(role, response.text)
  61. self.assertNotIn('Invalid', response.text)
  62. def test_assignment_creates_record_and_returns_only_detail_field(self):
  63. response = self.post()
  64. self.assertEqual(response.status_code, 200)
  65. self.assertIn('hx-swap-oob="outerHTML"', response.text)
  66. self.assertIn('Alice', response.text)
  67. self.assertNotIn('id="formular"', response.text)
  68. self.assertNotIn('HX-Redirect', response.headers)
  69. self.assertIn('gc:verursacherSaved', response.headers['HX-Trigger-After-Swap'])
  70. self.assertEqual(self.row()[2:5], ('alice', 'N', 'N'))
  71. self.assertEqual(self.db.commits, 1)
  72. self.assertIn('Alice', self.get().text)
  73. self.assertIn('Original Person', self.get().text)
  74. def test_change_and_reset_preserve_other_fields_and_original(self):
  75. self.db.connection.execute("INSERT INTO dbo.Forderungen_Details VALUES ('1', 'R1', 'alice', 'N', 'J', '2027-01-01')")
  76. self.db.connection.commit()
  77. self.post('bob')
  78. self.assertEqual(self.row()[2:], ('bob', 'N', 'J', '2027-01-01'))
  79. reset = self.post('', 'reset')
  80. self.assertEqual(self.row()[2:], (None, 'N', 'J', '2027-01-01'))
  81. self.assertIn('Original Person', reset.text)
  82. source = self.db.connection.execute("SELECT Verursacher_Text FROM dbo.Forderungen_Kopf WHERE Client_DB='1' AND Beleg_Nr='R1'").fetchone()
  83. self.assertEqual(source[0], 'Original Person')
  84. def test_reset_without_record_does_not_create_one(self):
  85. self.assertEqual(self.post('', 'reset').status_code, 200)
  86. self.assertIsNone(self.row())
  87. def test_list_success_refreshes_filters_and_focus(self):
  88. response = self.post(view='liste')
  89. self.assertEqual(response.status_code, 200)
  90. destination = response.headers['HX-Redirect']
  91. self.assertEqual(urlsplit(destination).path, '/app/forderungen/liste')
  92. self.assertEqual(parse_qs(urlsplit(destination).query), {'Filiale': ['10'], 'Verursacher': ['Original'], 'focus': ['1_R1']})
  93. def test_invalid_selection_and_database_failure_keep_modal_selection(self):
  94. self.assertEqual(self.post('not-a-user').status_code, 422)
  95. self.assertIsNone(self.row())
  96. self.assertEqual(self.db.commits, 0)
  97. with patch.object(self.db, 'commit', side_effect=RuntimeError('offline')), self.assertLogs('app.verursacher', level='ERROR'):
  98. response = self.post('alice', rolle='Buchhaltung')
  99. self.assertEqual(response.status_code, 503)
  100. self.assertIn('selected>Alice', response.text)
  101. self.assertIn('value="Buchhaltung" selected', response.text)
  102. self.assertIsNone(self.row())
  103. def test_rights_csrf_and_immutable_target(self):
  104. self.assertEqual(self.get(key='1_R2').status_code, 404)
  105. self.assertEqual(self.post(key='1_R2').status_code, 404)
  106. self.assertEqual(self.client.post(self.url(), data={'benutzer_id': 'alice'}).status_code, 403)
  107. self.assertEqual(self.post(Client_DB='2', Beleg_Nr='R2').status_code, 200)
  108. self.assertEqual(self.row()[2], 'alice')
  109. self.assertEqual(self.db.connection.execute('SELECT COUNT(*) FROM dbo.Forderungen_Details').fetchone()[0], 1)
  110. def test_multiple_roles_do_not_multiply_state_rows(self):
  111. self.post()
  112. result = self.db.execute(STATE_SQL, {'Client_DB': '1', 'Beleg_Nr': 'R1'}).all()
  113. self.assertEqual(len(result), 1)
  114. self.assertEqual(result[0].Verursacher_Text, 'Alice')
  115. self.assertEqual(result[0].Original_Verursacher_Text, 'Original Person')
  116. def test_direct_request_returns_full_page_and_rejects_external_return(self):
  117. for view in ['liste', 'details']:
  118. response = self.client.get(self.url(view), follow_redirects=False)
  119. self.assertEqual(response.status_code, 303)
  120. self.assertNotIn('/verursacher', response.headers['location'])
  121. url = '/app/forderungen/liste/1_R1/verursacher?return_to=https://evil.test'
  122. self.assertEqual(self.client.get(url, follow_redirects=False).headers['location'], '/app/forderungen/liste?focus=1_R1')
  123. def test_login_recovery_from_both_modal_views_and_no_write_replay(self):
  124. self.client.cookies.clear()
  125. for view in ['liste', 'details']:
  126. response = self.post(view=view)
  127. login = response.headers['HX-Redirect']
  128. target = parse_qs(urlsplit(login).query)['next'][0]
  129. self.assertNotIn('/verursacher', target)
  130. self.assertEqual(target, normalize_page_url(self.url(view)))
  131. self.assertIn('/app/forderungen/'+view, target)
  132. self.assertIsNone(self.row())
  133. if __name__ == '__main__':
  134. unittest.main()