| 123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153 |
- """Production assignee handlers and SQL, with SQL Server lock hints adapted for SQLite."""
- import re
- import unittest
- from unittest.mock import patch
- from urllib.parse import parse_qs, urlencode, urlsplit
- from app.navigation import normalize_page_url
- from app.verursacher import STATE_SQL
- from tests import test_forderung_history as fixture
- class VerursacherTests(unittest.TestCase):
- def setUp(self):
- self.fixture = fixture.HistoryTests()
- self.fixture.setUp()
- self.addCleanup(self.fixture.doCleanups)
- self.db, self.client = self.fixture.db, self.fixture.client
- self.db.connection.executescript("""
- ALTER TABLE dbo.Forderungen_Kopf ADD Verursacher_Benutzer_ID TEXT;
- ALTER TABLE dbo.Forderungen_Kopf ADD Verursacher_Text TEXT;
- UPDATE dbo.Forderungen_Kopf SET Verursacher_Benutzer_ID = 'original', Verursacher_Text = 'Original Person';
- INSERT INTO dbo.Benutzer_Rolle (Benutzer_ID, Name, Rolle_Name) VALUES
- ('original', 'Original Person', 'Service'),
- ('alice', 'Alice', 'Service'), ('alice', 'Alice', 'Buchhaltung'),
- ('bob', 'Bob', 'Leitung'), ('id-only', NULL, NULL), ('', 'Invalid', 'Service');
- CREATE TABLE dbo.Forderungen_Details (
- Client_DB TEXT, Beleg_Nr TEXT, Verursacher_Benutzer_ID TEXT,
- Bearbeitet TEXT DEFAULT 'N', Versicherung TEXT DEFAULT 'N', Wiedervorlage TEXT,
- PRIMARY KEY (Client_DB, Beleg_Nr)
- );
- """)
- self.db.connection.commit()
- execute = self.db.execute
- def adapted(query, values=None):
- sql = re.sub(r'\s+WITH \(UPDLOCK, HOLDLOCK\)', '', str(query))
- result = execute(sql, values)
- result.all = lambda: result.rows
- return result
- mocked = patch.object(self.db, 'execute', side_effect=adapted)
- mocked.start(); self.addCleanup(mocked.stop)
- self.db.rollback = self.db.connection.rollback
- self.origin = '/app/forderungen/liste?Filiale=10&Verursacher=Original'
- def url(self, view='details', key='1_R1'):
- return f'/app/forderungen/{view}/{key}/verursacher?' + urlencode({'return_to': self.origin})
- def get(self, view='details', key='1_R1'):
- return self.client.get(self.url(view, key), headers={'HX-Request': 'true'})
- def post(self, identity='alice', action='assign', view='details', key='1_R1', **extra):
- return self.client.post(self.url(view, key), data={
- 'benutzer_id': identity, 'action': action, **extra,
- }, headers={'HX-Request': 'true', 'X-CSRF-Token': 'csrf'})
- def row(self):
- return self.db.connection.execute('SELECT * FROM dbo.Forderungen_Details WHERE Client_DB = ? AND Beleg_Nr = ?', ('1', 'R1')).fetchone()
- def test_modal_deduplicates_people_but_keeps_all_roles_and_preselection(self):
- response = self.get()
- self.assertEqual(response.status_code, 200)
- self.assertNotIn('<html', response.text)
- self.assertEqual(response.text.count('value="alice"'), 1)
- self.assertNotIn('value="" data-roles=', response.text)
- self.assertIn('value="original" data-roles=', response.text)
- self.assertIn('selected>Original Person', response.text)
- self.assertIn('id-only (id-only)', response.text)
- for role in ['Service', 'Buchhaltung', 'Leitung']:
- self.assertIn(role, response.text)
- self.assertNotIn('Invalid', response.text)
- def test_assignment_creates_record_and_returns_only_detail_field(self):
- response = self.post()
- self.assertEqual(response.status_code, 200)
- self.assertIn('hx-swap-oob="outerHTML"', response.text)
- self.assertIn('Alice', response.text)
- self.assertNotIn('id="formular"', response.text)
- self.assertNotIn('HX-Redirect', response.headers)
- self.assertIn('gc:verursacherSaved', response.headers['HX-Trigger-After-Swap'])
- self.assertEqual(self.row()[2:5], ('alice', 'N', 'N'))
- self.assertEqual(self.db.commits, 1)
- self.assertIn('Alice', self.get().text)
- self.assertIn('Original Person', self.get().text)
- def test_change_and_reset_preserve_other_fields_and_original(self):
- self.db.connection.execute("INSERT INTO dbo.Forderungen_Details VALUES ('1', 'R1', 'alice', 'N', 'J', '2027-01-01')")
- self.db.connection.commit()
- self.post('bob')
- self.assertEqual(self.row()[2:], ('bob', 'N', 'J', '2027-01-01'))
- reset = self.post('', 'reset')
- self.assertEqual(self.row()[2:], (None, 'N', 'J', '2027-01-01'))
- self.assertIn('Original Person', reset.text)
- source = self.db.connection.execute("SELECT Verursacher_Text FROM dbo.Forderungen_Kopf WHERE Client_DB='1' AND Beleg_Nr='R1'").fetchone()
- self.assertEqual(source[0], 'Original Person')
- def test_reset_without_record_does_not_create_one(self):
- self.assertEqual(self.post('', 'reset').status_code, 200)
- self.assertIsNone(self.row())
- def test_list_success_refreshes_filters_and_focus(self):
- response = self.post(view='liste')
- self.assertEqual(response.status_code, 200)
- destination = response.headers['HX-Redirect']
- self.assertEqual(urlsplit(destination).path, '/app/forderungen/liste')
- self.assertEqual(parse_qs(urlsplit(destination).query), {'Filiale': ['10'], 'Verursacher': ['Original'], 'focus': ['1_R1']})
- def test_invalid_selection_and_database_failure_keep_modal_selection(self):
- self.assertEqual(self.post('not-a-user').status_code, 422)
- self.assertIsNone(self.row())
- self.assertEqual(self.db.commits, 0)
- with patch.object(self.db, 'commit', side_effect=RuntimeError('offline')), self.assertLogs('app.verursacher', level='ERROR'):
- response = self.post('alice', rolle='Buchhaltung')
- self.assertEqual(response.status_code, 503)
- self.assertIn('selected>Alice', response.text)
- self.assertIn('value="Buchhaltung" selected', response.text)
- self.assertIsNone(self.row())
- def test_rights_csrf_and_immutable_target(self):
- self.assertEqual(self.get(key='1_R2').status_code, 404)
- self.assertEqual(self.post(key='1_R2').status_code, 404)
- self.assertEqual(self.client.post(self.url(), data={'benutzer_id': 'alice'}).status_code, 403)
- self.assertEqual(self.post(Client_DB='2', Beleg_Nr='R2').status_code, 200)
- self.assertEqual(self.row()[2], 'alice')
- self.assertEqual(self.db.connection.execute('SELECT COUNT(*) FROM dbo.Forderungen_Details').fetchone()[0], 1)
- def test_multiple_roles_do_not_multiply_state_rows(self):
- self.post()
- result = self.db.execute(STATE_SQL, {'Client_DB': '1', 'Beleg_Nr': 'R1'}).all()
- self.assertEqual(len(result), 1)
- self.assertEqual(result[0].Verursacher_Text, 'Alice')
- self.assertEqual(result[0].Original_Verursacher_Text, 'Original Person')
- def test_direct_request_returns_full_page_and_rejects_external_return(self):
- for view in ['liste', 'details']:
- response = self.client.get(self.url(view), follow_redirects=False)
- self.assertEqual(response.status_code, 303)
- self.assertNotIn('/verursacher', response.headers['location'])
- url = '/app/forderungen/liste/1_R1/verursacher?return_to=https://evil.test'
- self.assertEqual(self.client.get(url, follow_redirects=False).headers['location'], '/app/forderungen/liste?focus=1_R1')
- def test_login_recovery_from_both_modal_views_and_no_write_replay(self):
- self.client.cookies.clear()
- for view in ['liste', 'details']:
- response = self.post(view=view)
- login = response.headers['HX-Redirect']
- target = parse_qs(urlsplit(login).query)['next'][0]
- self.assertNotIn('/verursacher', target)
- self.assertEqual(target, normalize_page_url(self.url(view)))
- self.assertIn('/app/forderungen/'+view, target)
- self.assertIsNone(self.row())
- if __name__ == '__main__':
- unittest.main()
|