test_wiedervorlage.py 10 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191
  1. """Follow-up date and audit comment are one protected transaction."""
  2. from datetime import date, datetime
  3. import unittest
  4. from unittest.mock import patch
  5. from urllib.parse import parse_qs, urlencode, urlsplit
  6. from app.navigation import normalize_page_url
  7. from app.wiedervorlage import BERLIN, _as_date
  8. from tests import test_verursacher as fixture
  9. class WiedervorlageTests(unittest.TestCase):
  10. def setUp(self):
  11. self.fixture = fixture.VerursacherTests()
  12. self.fixture.setUp()
  13. self.addCleanup(self.fixture.doCleanups)
  14. self.client, self.db = self.fixture.client, self.fixture.db
  15. self.db.connection.executescript("""
  16. ALTER TABLE dbo.Forderungen_Kopf ADD Beleg_Faellig_Datum TEXT;
  17. UPDATE dbo.Forderungen_Kopf SET Beleg_Faellig_Datum = '2026-10-15';
  18. """)
  19. self.db.connection.commit()
  20. self.origin = '/app/forderungen/liste?Filiale=10&WiedervorlageBis=2026-10-31'
  21. execute = self.db.execute
  22. def adapt_dates(query, values=None):
  23. values = {key: value.isoformat() if isinstance(value, (date, datetime)) else value
  24. for key, value in (values or {}).items()}
  25. return execute(query, values)
  26. adapter = patch.object(self.db, 'execute', side_effect=adapt_dates)
  27. adapter.start(); self.addCleanup(adapter.stop)
  28. self.now = datetime(2026, 10, 30, 0, 5, 12, tzinfo=BERLIN)
  29. clock = patch('app.wiedervorlage._now_berlin', return_value=self.now)
  30. clock.start(); self.addCleanup(clock.stop)
  31. def url(self, key='1_R1'):
  32. return f'/app/forderungen/liste/{key}/wiedervorlage?' + urlencode({'return_to': self.origin})
  33. def get(self, key='1_R1'):
  34. return self.client.get(self.url(key), headers={'HX-Request': 'true'})
  35. def post(self, value='2026-11-06', key='1_R1', **extra):
  36. return self.client.post(self.url(key), data={'wiedervorlage': value, **extra},
  37. headers={'HX-Request': 'true', 'X-CSRF-Token': 'csrf'})
  38. def row(self):
  39. return self.fixture.row()
  40. def comments(self):
  41. return self.db.connection.execute("SELECT Client_DB, Beleg_Nr, Benutzer_ID, Kommentar, Timestamp FROM dbo.Forderungen_Kommentar WHERE Kommentar LIKE 'WV auf %'").fetchall()
  42. def test_modal_prefills_list_fallback_and_berlin_shortcuts_without_writing(self):
  43. response = self.get()
  44. self.assertEqual(response.status_code, 200)
  45. self.assertIn('value="2026-10-15"', response.text)
  46. self.assertIn('data-gc-date="2026-10-30"', response.text)
  47. self.assertIn('data-gc-date="2026-11-06"', response.text)
  48. self.assertNotIn('<html', response.text)
  49. self.assertIsNone(self.row()); self.assertEqual(self.comments(), [])
  50. self.assertEqual(self.db.commits, 0)
  51. def test_shortcuts_cross_year_and_leap_day(self):
  52. for now, expected in [(datetime(2026, 12, 28, tzinfo=BERLIN), '2027-01-04'),
  53. (datetime(2028, 2, 22, tzinfo=BERLIN), '2028-02-29')]:
  54. with patch('app.wiedervorlage._now_berlin', return_value=now):
  55. self.assertIn('data-gc-date="'+expected+'"', self.get().text)
  56. def test_insert_date_comment_actor_timestamp_and_filtered_focus(self):
  57. response = self.post(Benutzer_ID='other', Client_DB='2', Beleg_Nr='R2')
  58. self.assertEqual(response.status_code, 200)
  59. self.assertEqual(self.row()[2:], (None, 'N', 'N', '2026-11-06'))
  60. comments = self.comments()
  61. self.assertEqual(len(comments), 1)
  62. self.assertEqual(comments[0][:4], ('1', 'R1', 'tester', 'WV auf 06.11.2026 angepasst'))
  63. self.assertEqual(datetime.fromisoformat(comments[0][4]), self.now.replace(tzinfo=None))
  64. self.assertEqual(self.db.commits, 1)
  65. destination = response.headers['HX-Redirect']
  66. self.assertEqual(parse_qs(urlsplit(destination).query),
  67. {'Filiale': ['10'], 'WiedervorlageBis': ['2026-10-31'], 'focus': ['1_R1']})
  68. def test_update_preserves_other_fields_and_preselects_saved_date(self):
  69. self.db.connection.execute("INSERT INTO dbo.Forderungen_Details VALUES ('1','R1','alice','N','J','2026-10-20')")
  70. self.db.connection.commit()
  71. self.assertIn('value="2026-10-20"', self.get().text)
  72. self.post()
  73. self.assertEqual(self.row()[2:], ('alice', 'N', 'J', '2026-11-06'))
  74. self.assertIn('value="2026-11-06"', self.get().text)
  75. def test_missing_date_can_be_assigned(self):
  76. self.db.connection.execute("UPDATE dbo.Forderungen_Kopf SET Beleg_Faellig_Datum = NULL WHERE Client_DB='1' AND Beleg_Nr='R1'")
  77. self.db.connection.commit()
  78. self.assertIn('value="" required', self.get().text)
  79. self.assertEqual(self.post().status_code, 200)
  80. self.assertEqual(self.row()[-1], '2026-11-06')
  81. self.assertEqual(len(self.comments()), 1)
  82. def test_same_date_and_repeated_submission_do_not_duplicate_comments(self):
  83. self.post('2026-10-15', begruendung='Nur eine Begründung')
  84. self.assertIsNone(self.row()); self.assertEqual(self.comments(), [])
  85. self.post(); self.post()
  86. self.assertEqual(len(self.comments()), 1)
  87. def test_optional_reason_is_trimmed_and_preserves_multiline_text(self):
  88. self.assertIn('name="begruendung" rows="3"', self.get().text)
  89. reason = ' Rücksprache <Kunde> & Fibu\nNeue Zusage '
  90. self.assertEqual(self.post(begruendung=reason).status_code, 200)
  91. self.assertEqual(self.comments()[0][3],
  92. 'WV auf 06.11.2026 angepasst: Rücksprache <Kunde> & Fibu\nNeue Zusage')
  93. self.assertEqual(self.post('2026-11-07', begruendung=' \n ').status_code, 200)
  94. self.assertEqual(self.comments()[1][3], 'WV auf 07.11.2026 angepasst')
  95. def test_reason_is_retained_and_escaped_on_validation_and_save_errors(self):
  96. reason = ' <script>Text</script> & Rückfrage\nZweite Zeile '
  97. response = self.post('invalid', begruendung=reason)
  98. self.assertEqual(response.status_code, 422)
  99. self.assertIn('&lt;script&gt;Text&lt;/script&gt; &amp; Rückfrage\nZweite Zeile</textarea>', response.text)
  100. with patch.object(self.db, 'commit', side_effect=RuntimeError('offline')), self.assertLogs('app.wiedervorlage', level='ERROR'):
  101. response = self.post(begruendung=reason)
  102. self.assertEqual(response.status_code, 503)
  103. self.assertIn('value="2026-11-06"', response.text)
  104. self.assertIn('&lt;script&gt;Text&lt;/script&gt; &amp; Rückfrage\nZweite Zeile</textarea>', response.text)
  105. self.assertEqual(self.comments(), [])
  106. def test_invalid_or_empty_dates_never_write(self):
  107. for value in ['', '2026-02-30', '2026-13-01', '30.10.2026', '20261030', "x'; DROP TABLE dbo.Forderungen_Details"]:
  108. with self.subTest(value=value):
  109. response = self.post(value)
  110. self.assertEqual(response.status_code, 422)
  111. self.assertIn('gültiges Wiedervorlagedatum', response.text)
  112. self.assertIsNone(self.row()); self.assertEqual(self.comments(), [])
  113. self.assertEqual(self.db.commits, 0)
  114. def test_comment_failure_rolls_back_existing_date_and_allows_retry(self):
  115. self.db.connection.execute("INSERT INTO dbo.Forderungen_Details VALUES ('1','R1','alice','N','J','2026-10-20')")
  116. self.db.connection.commit()
  117. execute = self.db.execute
  118. def failing(query, values=None):
  119. if 'INSERT INTO dbo.Forderungen_Kommentar' in str(query):
  120. raise RuntimeError('comment unavailable')
  121. return execute(query, values)
  122. with patch.object(self.db, 'execute', side_effect=failing), self.assertLogs('app.wiedervorlage', level='ERROR'):
  123. response = self.post()
  124. self.assertEqual(response.status_code, 503)
  125. self.assertNotIn('HX-Redirect', response.headers)
  126. self.assertIn('value="2026-11-06"', response.text)
  127. self.assertEqual(self.row()[2:], ('alice', 'N', 'J', '2026-10-20'))
  128. self.assertEqual(self.comments(), [])
  129. self.post()
  130. self.assertEqual(len(self.comments()), 1)
  131. def test_commit_failure_rolls_back_new_record_and_comment(self):
  132. with patch.object(self.db, 'commit', side_effect=RuntimeError('offline')), self.assertLogs('app.wiedervorlage', level='ERROR'):
  133. response = self.post()
  134. self.assertEqual(response.status_code, 503)
  135. self.assertIsNone(self.row()); self.assertEqual(self.comments(), [])
  136. def test_rights_csrf_and_native_redirect(self):
  137. self.assertEqual(self.get('1_R2').status_code, 404)
  138. self.assertEqual(self.post(key='1_R2').status_code, 404)
  139. self.assertEqual(self.client.post(self.url(), data={'wiedervorlage':'2026-11-06'}).status_code, 403)
  140. native = self.client.get(self.url(), follow_redirects=False)
  141. self.assertEqual(native.status_code, 303)
  142. self.assertNotIn('/wiedervorlage', native.headers['location'])
  143. self.assertIsNone(self.row())
  144. native_save = self.client.post(self.url(), data={'wiedervorlage':'2026-11-06'},
  145. headers={'X-CSRF-Token':'csrf'}, follow_redirects=False)
  146. self.assertEqual(native_save.status_code, 303)
  147. self.assertNotIn('/wiedervorlage', native_save.headers['location'])
  148. self.assertEqual(len(self.comments()), 1)
  149. def test_session_expiry_normalizes_full_list_without_replaying_post(self):
  150. self.client.cookies.clear()
  151. response = self.post()
  152. target = parse_qs(urlsplit(response.headers['HX-Redirect']).query)['next'][0]
  153. self.assertNotIn('/wiedervorlage', target)
  154. self.assertEqual(target, normalize_page_url(self.url()))
  155. self.assertIsNone(self.row()); self.assertEqual(self.comments(), [])
  156. self.assertEqual(normalize_page_url('/app/forderungen/liste/1_R1/wiedervorlage',
  157. current_url='https://proxy.test'+self.origin), target)
  158. self.assertEqual(normalize_page_url('/app/forderungen/liste/1_R1/wiedervorlage?return_to=https://evil.test'),
  159. '/app/forderungen/liste?focus=1_R1')
  160. def test_database_date_types(self):
  161. value = datetime(2026, 10, 30, 12, 30)
  162. self.assertEqual(_as_date(value), value.date())
  163. self.assertEqual(_as_date(value.date()), value.date())
  164. self.assertEqual(_as_date('2026-10-30 00:00:00'), value.date())
  165. self.assertIsNone(_as_date(None))
  166. if __name__ == '__main__':
  167. unittest.main()